cloud-fan commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1926315565
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -63,6 +67,79 @@ case class SqlScriptingInterpreter(session: SparkSession) {
case _ => None
}
+ /**
+ * Transform [[CompoundBody]] into [[CompoundBodyExec]].
+ *
+ * @param compoundBody
+ * CompoundBody to be transformed into CompoundBodyExec.
+ * @param args
+ * A map of parameter names to SQL literal expressions.
+ * @param isHandler
+ * Indicates if the body is a handler body to do additional processing
during transforming.
+ * @return
+ * Executable version of the CompoundBody .
+ */
+ private def transformBodyIntoExec(
+ compoundBody: CompoundBody,
+ args: Map[String, Expression],
+ context: SqlScriptingExecutionContext): CompoundBodyExec = {
+ // Add drop variables to the end of the body.
+ val variables = compoundBody.collection.flatMap {
+ case st: SingleStatement => getDeclareVarNameFromPlan(st.parsedPlan)
+ case _ => None
+ }
+ val dropVariables = variables
+ .map(varName => DropVariable(varName, ifExists = true))
+ .map(new SingleStatementExec(_, Origin(), args, isInternal = true,
context))
+ .reverse
+
+ // Create a map of conditions (SqlStates) to their respective handlers.
+ val conditionHandlerMap = HashMap[String, ErrorHandlerExec]()
+ compoundBody.handlers.foreach(handler => {
+ val handlerBodyExec =
+ transformBodyIntoExec(
+ handler.body,
+ args,
+ context)
+
+ // Execution node of handler.
+ val handlerScopeLabel = if (handler.handlerType == HandlerType.EXIT) {
+ Some(compoundBody.label.get)
+ } else {
+ None
+ }
+
+ val handlerExec = new ErrorHandlerExec(
+ handlerBodyExec,
+ handler.handlerType,
+ handlerScopeLabel)
+
+ // For each condition handler is defined for, add corresponding key
value pair
+ // to the conditionHandlerMap.
+ handler.conditions.foreach(condition => {
+ // Condition can either be the key in conditions map or SqlState.
Review Comment:
It's not something additional that we can follow up on later. It means the
current implementation uses the wrong abstraction and we should not ship it. We
must use the right data model for error conditions and handlers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
