Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5792#discussion_r31682176
  
    --- Diff: 
core/src/main/scala/org/apache/spark/status/api/v1/ApiRootResource.scala ---
    @@ -193,6 +206,13 @@ private[spark] trait UIRoot {
       def getSparkUI(appKey: String): Option[SparkUI]
       def getApplicationInfoList: Iterator[ApplicationInfo]
     
    +  def writeEventLogs(appId: String, attemptId: Option[String], zipStream: 
ZipOutputStream): Unit = {
    --- End diff --
    
    This needs a java doc since it's technically not the same as the one you 
defined in `ApplicationHistoryProvider`. We should expand on why attemptId is 
an option (what happens if it's `None`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to