MaxGekk commented on code in PR #49623:
URL: https://github.com/apache/spark/pull/49623#discussion_r1927475510
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/NormalizePlan.scala:
##########
@@ -41,10 +41,12 @@ object NormalizePlan extends PredicateHelper {
def normalizeExpressions(plan: LogicalPlan): LogicalPlan = {
val withNormalizedRuntimeReplaceable = normalizeRuntimeReplaceable(plan)
withNormalizedRuntimeReplaceable transformAllExpressions {
- case c: CommonExpressionDef =>
- c.copy(id = new CommonExpressionId(id = 0))
- case c: CommonExpressionRef =>
- c.copy(id = new CommonExpressionId(id = 0))
+ case commonExpressionDef: CommonExpressionDef =>
+ commonExpressionDef.copy(id = new CommonExpressionId(id = 0))
+ case commonExpressionRef: CommonExpressionRef =>
+ commonExpressionRef.copy(id = new CommonExpressionId(id = 0))
+ case expressionWithRandomSeed: ExpressionWithRandomSeed =>
Review Comment:
PR's title `Normalize non-deterministic expressions` addresses wider scope,
could you make it more concrete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
