ueshin commented on code in PR #49535:
URL: https://github.com/apache/spark/pull/49535#discussion_r1927835027
##########
python/pyspark/util.py:
##########
@@ -462,22 +462,40 @@ def wrapped(*args: Any, **kwargs: Any) -> Any:
return f # type: ignore[return-value]
-def handle_worker_exception(e: BaseException, outfile: IO) -> None:
+def handle_worker_exception(
+ e: BaseException, outfile: IO, hide_traceback: Optional[bool] = None
Review Comment:
I don't see any place that passes this parameter except for the tests.
I just thought `test_env_full` and `test_env_hide_traceback` are enough
without taking it here?
If we want to take this, we need more tests, like "setting env but pass it"
will ignore the env var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
