wayneguow commented on PR #49564: URL: https://github.com/apache/spark/pull/49564#issuecomment-2613835599
> Thank you, @wayneguow . > > This looks like a valid suggestion if we have a validation for the user-provided hint string is a valid comment like `/*+... */` always. > > BTW, did you exclude `MSSQL` Hint because the syntax style is different and not a comment? > > ``` > SELECT * > > FROM Customers > > WHERE City = 'San Francisco' > > OPTION (USE INDEX = IX_City); > ``` @dongjoon-hyun Yes, I have excluded `SQL Server` currently. On the one hand, its hints are not in the form of comments, and on the other hand, its hints can appear in many places: Example 1： `SELECT * FROM Orders WITH (INDEX(OrderDate_Index)) WHERE OrderDate > '2024-01-01';` Example 2: `SELECT * FROM Customers C INNER JOIN Orders O ON C.CustomerID = O.CustomerID WITH (LOOP JOIN);` It is currently difficult to deal with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
