LuciferYang commented on code in PR #48818:
URL: https://github.com/apache/spark/pull/48818#discussion_r1929696580
##########
sql/connect/shims/src/main/scala/org/apache/spark/shims.scala:
##########
@@ -35,6 +35,7 @@ package sql {
package execution {
class QueryExecution
+ class SparkStrategy
Review Comment:
So, if GA executes a test case that catches this class loading issue first,
it will pass the test(like sbt GA), for example, by testing
`LiteralExpressionSuite` before testing `EncoderResolutionSuite`.
```
build/sbt clean "catalyst/testOnly
org.apache.spark.sql.catalyst.expressions.LiteralExpressionSuite
org.apache.spark.sql.catalyst.encoders.EncoderResolutionSuite"
```
However, if CI executes `EncoderResolutionSuite` first, the test will
fail(like maven GA), such as:
```
build/sbt clean "catalyst/testOnly
org.apache.spark.sql.catalyst.encoders.EncoderResolutionSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
