Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6430#discussion_r31683713
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -261,14 +269,19 @@ private[spark] class ExecutorAllocationManager(
       private def updateAndSyncNumExecutorsTarget(now: Long): Int = 
synchronized {
         val maxNeeded = maxNumExecutorsNeeded
     
    -    if (maxNeeded < numExecutorsTarget) {
    +    if (initializing && (maxNeeded < numExecutorsTarget)) {
    +      // when ExecutorAllocationManager is still in initializing status,
    +      // and the max number of needed executors is less than the initial 
number of executors,
    +      // we just return without doing anything.
    --- End diff --
    
    I would rephrase this:
    ```
    // Do not cancel requests while we are still initializing,
    // otherwise the first job may have to ramp up unnecessarily
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to