attilapiros commented on PR #49094: URL: https://github.com/apache/spark/pull/49094#issuecomment-2617345480
As your solution changed you should update the PR description accordingly. By introducing `total_tasks` the already existing `num_tasks` lost it purpose: At least from both the `BatchPage` and the `AllJobsPage` `num_tasks` is replaced by `total_tasks`. This does nots seems to me right! Especially as `numSkippedTasks` is based on the `total_tasks`. Moreover the unit test does not test the new `total_tasks` at all. Is it possible to write a test which covers the problem we seen in the UI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
