mihailoale-db commented on code in PR #49750:
URL: https://github.com/apache/spark/pull/49750#discussion_r1938266113
##########
sql/core/src/test/resources/sql-tests/inputs/group-by.sql:
##########
@@ -64,6 +78,10 @@ set spark.sql.groupByAliases=false;
-- Check analysis exceptions
SELECT a AS k, COUNT(b) FROM testData GROUP BY k;
+SELECT 1 GROUP BY `1`;
Review Comment:
Idea was to add some tests that should fail (with `set
spark.sql.groupByAliases=false;`). I can remove them if needed
##########
sql/core/src/test/resources/sql-tests/analyzer-results/group-by.sql.out:
##########
@@ -320,6 +389,38 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException
}
+-- !query
+SELECT 1 GROUP BY `1`
+-- !query analysis
+org.apache.spark.sql.catalyst.ExtendedAnalysisException
+{
+ "errorClass" : "UNRESOLVED_COLUMN.WITHOUT_SUGGESTION",
Review Comment:
Idea was to add some tests that should fail (with `set
spark.sql.groupByAliases=false;`). I can remove them if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
