cloud-fan commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1938488304
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SqlScriptingLogicalPlans.scala:
##########
@@ -17,9 +17,14 @@
package org.apache.spark.sql.catalyst.plans.logical
+import java.util.Locale
+
+import scala.collection.mutable.{HashMap, Set}
Review Comment:
This is anti-pattern as it overrides the default `Set` in this file with
mutable `Set`.
The recommended way is to import `scala.collection.mutable` and use
`mutable.Set` explicitly within this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
