miland-db commented on PR #49427: URL: https://github.com/apache/spark/pull/49427#issuecomment-2630568618
- Basically, we are doing uniqueness check for condition names in `ExceptionHandlerTriggers.addUnique*` methods where case sensitivity is centralized and strings are converted to the same casing . - When creating `ErrorCondition` object, we pass upper-case arguments. - We use upper-case when we check if condition is builtin Spark condition. I agree more centralized approach should be used, but with current tests, I think we covered all possible checks in code to be case-insensitive. As a follow up, I will try to think of some more clever way of ensuring **case-insensitivity** because this can be a problem if somebody change or add new code without case-sensitivity in mind. Thanks for the comment! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
