cloud-fan commented on code in PR #49715:
URL: https://github.com/apache/spark/pull/49715#discussion_r1944355476
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -579,23 +592,52 @@ case class AdaptiveSparkPlanExec(
allChildStagesMaterialized = false,
newStages = Seq(newStage))
- case q: QueryStageExec =>
+ case q: QueryStageExec if q ne currentPhysicalPlan =>
Review Comment:
ah I see, let's add comments to explain it
```
// We can skip creating a new query stage if the given plan is already a
query stage.
// Note: if this query stage is a root node, we still need to create a
result query stage.
```
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala:
##########
@@ -579,23 +592,52 @@ case class AdaptiveSparkPlanExec(
allChildStagesMaterialized = false,
newStages = Seq(newStage))
- case q: QueryStageExec =>
+ case q: QueryStageExec if q ne currentPhysicalPlan =>
Review Comment:
ah I see, let's add comments to explain it
```
// We can skip creating a new query stage if the given plan is already a
query stage.
// Note: if this query stage is the root node, we still need to create a
result query stage.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
