Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6625#discussion_r31689514
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala ---
    @@ -125,6 +125,13 @@ private[spark] object SerializationDebugger extends 
Logging {
           return List.empty
         }
     
    +    /**
    +     * Visit an externalizable object.
    +     * Since writeExternal() can choose add arbitrary objects at the time 
of serialization,
    +     * the only way to capture all the objects it will serialize is by 
using a
    +     * dummy ObjectOutput object that captures all the inner objects, and 
then visit all the
    --- End diff --
    
    This is a really long sentence and fairly low level. How about:
    ```
    Since writeExternal() can choose add arbitrary objects at the time of 
serialization,
    the only way to capture all the objects it will serialize is to manually 
write the object
    into our own dummy ObjectOutput that collects the relevant fields.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to