harshmotw-db commented on PR #49609: URL: https://github.com/apache/spark/pull/49609#issuecomment-2643706305
@cloud-fan @HyukjinKwon I think the Spark Connect tests passed because of [the code for `lit`](https://github.com/apache/spark/blob/f5f7c365d519c4f9d4b7a5dce2c8a047cf051899/python/pyspark/sql/connect/functions/builtin.py#L260-L264). If the input to `lit` is a column, it routes to the column anyway. My code is kind of redundant, but I think we should keep it as is because we shouldn't rely on this internal behavior of `lit`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
