cnauroth commented on PR #49858: URL: https://github.com/apache/spark/pull/49858#issuecomment-2649887978
> BTW, I'm investigating the relevant code at this chance while reviewing this PR. It's because the existing test coverage also looks suspicious due to `val callerContextEnabled`. The code of this PR itself looks okay, but let me figure out what is the best way to test Spark's `Hadoop Caller Context` support. Sorry for the delay. > > https://github.com/apache/spark/blob/6a668cde87c397871718fa38abb182e23af5dd49/core/src/test/scala/org/apache/spark/util/UtilsSuite.scala#L1005-L1011 If coverage looks suspicious, then it might be that the flag is only initialized once per JVM startup, and test runs probably don't have configuration for `hadoop.caller.context.enabled=true`. Steve hinted at this in #49779. My test helper is trying to work around this (with the downside of compromising visibility and mutability of the flag). No worries on the delay. Committers are busy! 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
