zecookiez commented on code in PR #49816:
URL: https://github.com/apache/spark/pull/49816#discussion_r1951535348
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala:
##########
@@ -398,6 +427,25 @@ trait StateStoreWriter
}.toMap
}
+ private def stateStoreInstanceMetrics: Map[String, SQLMetric] = {
+ val provider = StateStoreProvider.create(conf.stateStoreProviderClass)
+ val maxPartitions = conf.defaultNumShufflePartitions
+
+ (0 until maxPartitions).flatMap { partitionId =>
+ provider.supportedInstanceMetrics.flatMap { metric =>
+ val storeNames = if (isJoinOperator) {
+ SymmetricHashJoinStateManager.allStateStoreNames(LeftSide, RightSide)
Review Comment:
This makes sense, and turns out we already have `stateStoreNames` defined
the way we want it in StreamingSymmetricHashJoinExec 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
