vladimirg-db commented on code in PR #49835:
URL: https://github.com/apache/spark/pull/49835#discussion_r1952155895


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -5554,6 +5554,18 @@ object SQLConf {
     .booleanConf
     .createWithDefault(true)
 
+  val LEGACY_PARSE_QUERY_WITHOUT_EOF = 
buildConf("spark.sql.legacy.parseQueryWithoutEof")
+    .internal()
+    .doc(
+      "When set to true, AbstractSqlParser.parseQuery(...) is going to use 
base `query` grammar " +

Review Comment:
   Aren't we trying to say that this specific code (`AbstractSqlParser`) has 
this legacy behavior?
   
   But I assume this is a common base class for `CatalystSqlParser` and 
`SparkSqlParser`, so we could also put it like you sugest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to