Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/6479#issuecomment-108749295
  
    As long as we're removing quasiquotes, we might see if we can delete their 
dependencies from the `pom` as well:
    
    I think we might be able to remove the following (should confirm, though):
    
    ```
     <profiles>
         <!-- Quasiquotes are merged into scala reflect from scala 2.11 
onwards. -->
         <profile>
           <id>scala-2.10</id>
           <activation>
             <property><name>!scala-2.11</name></property>
           </activation>
           <dependencies>
             <dependency>
               <groupId>org.scalamacros</groupId>
               <artifactId>quasiquotes_${scala.binary.version}</artifactId>
               <version>${scala.macros.version}</version>
             </dependency>
           </dependencies>
         </profile>
       </profiles>
    ```
    
    and
    
    ```
         <dependency>
           <groupId>org.scala-lang</groupId>
           <artifactId>scala-compiler</artifactId>
         </dependency>
    ```
    
    We might have to keep
    
    ```
         <dependency>
           <groupId>org.scala-lang</groupId>
           <artifactId>scala-reflect</artifactId>
         </dependency>
    ```
    
    if we actually depend on Scala reflection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to