cloud-fan commented on code in PR #49726:
URL: https://github.com/apache/spark/pull/49726#discussion_r1954815751


##########
sql/core/src/test/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionSuite.scala:
##########
@@ -69,6 +70,222 @@ class SqlScriptingExecutionSuite extends QueryTest with 
SharedSparkSession {
     }
   }
 
+  // Signal tests
+  test("signal statement - condition") {
+    val sqlScript =
+      """
+        |BEGIN
+        |  DECLARE TEST_CONDITION CONDITION FOR SQLSTATE '12345';
+        |  SIGNAL TEST_CONDITION;
+        |END
+        |""".stripMargin
+    val exception = intercept[SqlScriptingRuntimeException] {
+      verifySqlScriptResult(sqlScript, Seq.empty)
+    }
+    checkError(

Review Comment:
   Can you also run this test manually and check the user-facing error message? 
To make sure that the error context (line number) is properly displayed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to