cloud-fan commented on code in PR #49907:
URL: https://github.com/apache/spark/pull/49907#discussion_r1956187110
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -390,10 +390,6 @@ case class PercentileCont(left: Expression, right:
Expression, reverse: Boolean
override protected def withNewChildrenInternal(
newLeft: Expression, newRight: Expression): PercentileCont =
this.copy(left = newLeft, right = newRight)
-
- override def orderingFilled: Boolean = left != UnresolvedWithinGroup
Review Comment:
I think the previous version is better as we don't need this hidden
assumption. I also don't think this PR improves the code, as requiring the
implementation to implement these method can force them to think about the
semantic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
