HyukjinKwon commented on code in PR #49880:
URL: https://github.com/apache/spark/pull/49880#discussion_r1961210187
##########
python/pyspark/sql/connect/session.py:
##########
@@ -1072,6 +1083,13 @@ def _start_connect_server(master: str, opts: Dict[str,
Any]) -> None:
conf.setAll(list(overwrite_conf.items())).setAll(list(default_conf.items()))
PySparkSession(SparkContext.getOrCreate(conf))
+ # In Python local mode, session.stop does not terminate JVM
itself
Review Comment:
> How about you set the environment variable when we start spark?
Yeah I think that's a good idea.
> Also how do you ensure the LocalAuthInterceptor will installed if there is
no token yet?
It is ensured by being blocked SparkConext with Spark Connect server is
running. And then, here we create a Spark Connect client. So the token will
always be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
