LuciferYang commented on code in PR #50005:
URL: https://github.com/apache/spark/pull/50005#discussion_r1963688150
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanner.scala:
##########
@@ -30,9 +29,9 @@ import
org.apache.spark.sql.execution.datasources.v2.DataSourceV2Strategy
import org.apache.spark.sql.internal.SQLConf
class SparkPlanner(val session: SparkSession, val experimentalMethods:
ExperimentalMethods)
- extends SparkStrategies with SQLConfHelper {
+ extends SparkStrategies {
- override def conf: SQLConf = session.sessionState.conf
+ protected def conf: SQLConf = session.sessionState.conf
Review Comment:
1. Are there any other similar cases?
2. Since this case is somewhat different from the other cases in the PR,
could we specifically mention it in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
