szehon-ho commented on code in PR #49963:
URL: https://github.com/apache/spark/pull/49963#discussion_r1964245074
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -142,22 +142,22 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
}
/**
- * Replaces the expression of CurrentDatabase with the current database name.
- * Replaces the expression of CurrentCatalog with the current catalog name.
+ * Replaces the expression of CurrentDatabase, CurrentCatalog, and CurrentUser
+ * with the current values.
*/
case class ReplaceCurrentLike(catalogManager: CatalogManager) extends
Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
- val currentNamespace = catalogManager.currentNamespace.quoted
- val currentCatalog = catalogManager.currentCatalog.name()
- val currentUser = CurrentUserContext.getCurrentUser
Review Comment:
Got it, thanks all for explanation, I made the update patch:
https://github.com/apache/spark/pull/50028
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/finishAnalysis.scala:
##########
@@ -142,22 +142,22 @@ object ComputeCurrentTime extends Rule[LogicalPlan] {
}
/**
- * Replaces the expression of CurrentDatabase with the current database name.
- * Replaces the expression of CurrentCatalog with the current catalog name.
+ * Replaces the expression of CurrentDatabase, CurrentCatalog, and CurrentUser
+ * with the current values.
*/
case class ReplaceCurrentLike(catalogManager: CatalogManager) extends
Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = {
import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
- val currentNamespace = catalogManager.currentNamespace.quoted
- val currentCatalog = catalogManager.currentCatalog.name()
- val currentUser = CurrentUserContext.getCurrentUser
Review Comment:
Got it, thanks all for explanation, I made the follow-up PR:
https://github.com/apache/spark/pull/50028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
