ahshahid opened a new pull request, #50029:
URL: https://github.com/apache/spark/pull/50029
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Added a new lazy boolean exprValHasIndeterministicCharacter in the
Expression class, to indicate whether the expression's evaluation result was
obtained using some indeterministic calculation.
The main difference between existing deterministic boolean and this is ,
that the former determines if same expression is evaluated more than once in a
given iteration would its value change or not. Also on that basis, any leaf
expression would always be deterministic.
But the latter indicates if an expression's evaluation used/uses any non
deterministic component. So here even the leaf expression ( like Attribute)
can have non deterministic character flag as true, if its pointing to some
result obtained via indeterministic calculation.
Apart from that code of ShuffleDependency is augmented to indicate if the
hashing expression is using any non deterministic component.
### Why are the changes needed?
The method Stage.isIndeterminate is not returning true in case the
ShuffleDependency is using Partitioner based on an inDeterministic Attribute.
The bug is at Stage and RDD level. An expression which is using an Attribute
derived from an inDeterministic Expression, looses the information, that its
Output is using an InDeterministic component.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added unit tests / Bug test to validate the behaviour of InDeterministic
Stages
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
