LuciferYang commented on code in PR #50049:
URL: https://github.com/apache/spark/pull/50049#discussion_r1966674969
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLogSuite.scala:
##########
@@ -31,8 +29,6 @@ import org.apache.spark.util.UninterruptibleThread
class HDFSMetadataLogSuite extends SharedSparkSession {
- private implicit def toOption[A](a: A): Option[A] = Option(a)
Review Comment:
https://github.com/apache/spark/pull/11897/files#diff-6a3f4a617cb70b130c99d3765b8509b386d735255561e5488025462a79afd6d0
From the initial code, it seems to have been added to fix a compilation
issue.
However, in the current codebase, removing it does not affect the
compilation process. And I manually verified that both the Maven compilation
and tests can be successfully executed without it, so I think it can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
