hvanhovell commented on code in PR #50013:
URL: https://github.com/apache/spark/pull/50013#discussion_r1968701252
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -313,4 +313,49 @@ object Connect {
.internal()
.booleanConf
.createWithDefault(true)
+
+ val CONNECT_SESSION_ML_CACHE_TIMEOUT =
+ buildConf("spark.connect.session.mlCache.timeout")
Review Comment:
I am not sure if we can do this. This is a non-recoverable situation for a
client. The client itself should tell us they are done with a model. I would
suggest instead that we either fail and give them a list of models they can
evict, or that we store old models on disk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
