jingz-db commented on code in PR #49560:
URL: https://github.com/apache/spark/pull/49560#discussion_r1970393438
##########
sql/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -1031,6 +1031,26 @@ message GroupMap {
// (Optional) The schema for the grouped state.
optional DataType state_schema = 10;
+
+ // Below fields are used by TransformWithState and TransformWithStateInPandas
+ // (Optional) TransformWithState related parameters.
+ optional TransformWithStateInfo transform_with_state_info = 11;
+}
+
+// Additional input parameters used for TransformWithState operator.
+message TransformWithStateInfo {
Review Comment:
Yeah... If we want to move FMGWS related fields into:
```
oneof stateInfo {
MapGroupsWithStateInfo = xx;
TransformWithStateInfo = yy;
}
```
Then it has to be non-additive changes. So we should probably keep FMGWS the
way it is at the moment and make a separate schema for TWS so that if any
future operator is added, it can follow what TWS is doing and have a better
structure.
##########
sql/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -1031,6 +1031,26 @@ message GroupMap {
// (Optional) The schema for the grouped state.
optional DataType state_schema = 10;
+
+ // Below fields are used by TransformWithState and TransformWithStateInPandas
+ // (Optional) TransformWithState related parameters.
+ optional TransformWithStateInfo transform_with_state_info = 11;
+}
+
+// Additional input parameters used for TransformWithState operator.
+message TransformWithStateInfo {
Review Comment:
Yeah... If we want to move FMGWS related fields into:
```
oneof stateInfo {
MapGroupsWithStateInfo = xx;
TransformWithStateInfo = yy;
}
```
Then it has to be non-additive changes. So we should probably keep FMGWS the
way it is at the moment and make a separate schema for TWS so that if any
future operator is added, it can follow what TWS is doing and have a better
structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
