bart-samwel commented on code in PR #50135:
URL: https://github.com/apache/spark/pull/50135#discussion_r1977953635
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -845,31 +848,42 @@ class AstBuilder extends DataTypeAstBuilder
// 2. Write commands do not hold the table logical plan as a child,
and we need to add
// additional resolution code to resolve identifiers inside the
write commands.
case table: InsertIntoTableContext =>
- val (relationCtx, options, cols, partition, ifPartitionNotExists,
byName)
- = visitInsertIntoTable(table)
+ val InsertTableParams(
Review Comment:
By pattern matching like this, you still don't get verification that the
local names match the names in the case class, so you are still not safe
against e.g. order changes / accidental wrong order. Something like `val params
= ...` and then `params.userSpecifiedCols` etc. would work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
