gengliangwang commented on code in PR #50044:
URL: https://github.com/apache/spark/pull/50044#discussion_r1978057407
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2DataFrameSuite.scala:
##########
@@ -263,4 +264,38 @@ class DataSourceV2DataFrameSuite
spark.listenerManager.unregister(listener)
}
}
+
+ test("columns with default values") {
+ val tableName = "testcat.ns1.ns2.tbl"
+ withTable(tableName) {
+ sql(s"CREATE TABLE $tableName (id INT, dep STRING) USING foo")
Review Comment:
nit: let's also test creating a V2 table with column default values, and
then inserting into the V2 table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
