cloud-fan commented on code in PR #47998:
URL: https://github.com/apache/spark/pull/47998#discussion_r1979410799
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -417,8 +417,11 @@ private[client] class Shim_v2_0 extends Shim with Logging {
try {
val partitionSchema =
CharVarcharUtils.replaceCharVarcharWithStringInSchema(
catalogTable.partitionSchema)
+ val lowerCasePredicates = predicates.map(_.transform {
+ case a: AttributeReference =>
a.withName(a.name.toLowerCase(Locale.ROOT))
+ })
val boundPredicate =
ExternalCatalogUtils.generatePartitionPredicateByFilter(
- catalogTable, partitionSchema, predicates)
+ catalogTable, partitionSchema, lowerCasePredicates)
Review Comment:
interesting, I thought Hive is case insensitive and the column name case in
partition predicates doesn't matter. It's not the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
