cloud-fan commented on code in PR #50129:
URL: https://github.com/apache/spark/pull/50129#discussion_r1979443722


##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -253,6 +254,18 @@ protected String visitNot(String v) {
 
   protected String visitUnaryArithmetic(String name, String v) { return name + 
v; }
 
+  protected String visitCaseWhen(GeneralScalarExpression e) {
+    if (e instanceof Predicate) {

Review Comment:
   I don't quite understand this condition, what does it mean? There is no code 
comments at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to