dongjoon-hyun commented on code in PR #50145: URL: https://github.com/apache/spark/pull/50145#discussion_r1979635796
########## python/pyspark/sql/connect/client/core.py: ########## @@ -688,6 +690,19 @@ def __init__( # cleanup ml cache if possible atexit.register(self._cleanup_ml) + @staticmethod + def _check_if_closed(func: Callable) -> Callable: + @functools.wraps(func) + def wrapped(self: SparkConnectClient, *args: Any, **kwargs: Any) -> Any: Review Comment: ``` File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 696, in _check_if_closed def wrapped(self: SparkConnectClient, *args: Any, **kwargs: Any) -> Any: ^^^^^^^^^^^^^^^^^^ NameError: name 'SparkConnectClient' is not defined. Did you mean: 'SparkConnectException'? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org