zecookiez opened a new pull request, #50195:
URL: https://github.com/apache/spark/pull/50195
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
SPARK-51097
#50161 recently had to revert the changes in #49816 due to instance metrics
showing up on SparkUI, causing excessive clutter. This PR aims to re-introduce
the new instance metrics while incorporating the fix in #50157.
The main difference between this and the original PR are:
- Distinguishing metrics and instance metrics as a whole, so that SparkPlan
does not accidentally pick up hundreds of instance metrics
- Adding a test to the suite to verify that no nodes in the execution plan
contain the instance metrics we just introduced. Since SparkPlan nodes store
metrics as strings, distinguishing between metric types isn't possible in this
context. Thus, this test will only check for the specific metric we just
introduced.
- Small edit to another test to verify instance metric behavior as well.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
From #49816:
There's currently a lack of observability into state store specific
maintenance information, notably metrics of the last snapshot version uploaded.
This affects the ability to identify performance degradation issues behind
maintenance tasks and more as described in
[SPARK-51097](https://issues.apache.org/jira/browse/SPARK-51097).
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
new features, bug fixes, or other behavior changes. Documentation-only updates
are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
From #49816:
There will be some new metrics displayed from StreamingQueryProgress:
```
Streaming query made progress: {
...
"stateOperators" : [ {
...
"customMetrics" : {
...
"SnapshotLastUploaded.partition_0_default" : 2,
"SnapshotLastUploaded.partition_12_default" : 10,
"SnapshotLastUploaded.partition_8_default" : 10,
...
}
} ],
"sources" : ...,
"sink" : ...
}
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions
for the consistent environment, and the instructions could accord to:
https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Five tests are added to RocksDBStateStoreIntegrationSuite:
- The first four are identical to the tests from #49816, which verify
metrics are properly updating using custom faulty stores and different types of
stateful queries (deduplicate and join).
- The fifth test goes through the generated execution plan for stateful
queries to make sure no instance metric shows up.
I will also be adding SparkUI screenshots in the description to show that
the metrics aren't showing up on SparkUI anymore.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
