dongjoon-hyun commented on code in PR #4:
URL: https://github.com/apache/spark-connect-swift/pull/4#discussion_r1988317890


##########
README.md:
##########
@@ -1 +1,15 @@
-# Apache Spark Connect Client for Swift language
+# Apache Spark Connect Client for Swift
+
+[![GitHub Actions 
Build](https://github.com/apache/spark-connect-swift/actions/workflows/build_and_test.yml/badge.svg)](https://github.com/apache/spark-connect-swift/blob/main/.github/workflows/build_and_test.yml)
+
+This is an experimental Swift library to show how to connect to a remote 
Apache Spark Connect Server and run SQL statements to manipulate remote data.
+
+So far, this library project is tracking the upstream changes like the [Apache 
Spark](https://spark.apache.org) 4.0.0 RC2 release and [Apache 
Arrow](https://arrow.apache.org) project's Swift-support.
+
+## Requirement
+- [Apache Spark 4.0.0 RC2 (March 
2025)](https://dist.apache.org/repos/dist/dev/spark/v4.0.0-rc2-bin/)
+- [Swift 6.0 (2024)](https://swift.org)
+- [gRPC Swift 2.1 (March 
2025)](https://github.com/grpc/grpc-swift/releases/tag/2.1.0)
+- [gRPC Swift Protobuf 1.0 (March 
2025)](https://github.com/grpc/grpc-swift-protobuf/releases/tag/1.1.0)
+- [gRPC Swift NIO Transport 1.0 (March 
2025)](https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.0.1)
+- [Apache Arrow Swift](https://github.com/apache/arrow/tree/main/swift)

Review Comment:
   For now, Apache Arrow didn't make a `Swift` release and didn't compile it 
successfully on the latest Swift 6.0 version.
   
   So, I borrowed some files from Apache Arrow like Apache Spark did for Apache 
Hive Thrift Server module.



##########
README.md:
##########
@@ -1 +1,15 @@
-# Apache Spark Connect Client for Swift language
+# Apache Spark Connect Client for Swift
+
+[![GitHub Actions 
Build](https://github.com/apache/spark-connect-swift/actions/workflows/build_and_test.yml/badge.svg)](https://github.com/apache/spark-connect-swift/blob/main/.github/workflows/build_and_test.yml)
+
+This is an experimental Swift library to show how to connect to a remote 
Apache Spark Connect Server and run SQL statements to manipulate remote data.
+
+So far, this library project is tracking the upstream changes like the [Apache 
Spark](https://spark.apache.org) 4.0.0 RC2 release and [Apache 
Arrow](https://arrow.apache.org) project's Swift-support.
+
+## Requirement
+- [Apache Spark 4.0.0 RC2 (March 
2025)](https://dist.apache.org/repos/dist/dev/spark/v4.0.0-rc2-bin/)
+- [Swift 6.0 (2024)](https://swift.org)
+- [gRPC Swift 2.1 (March 
2025)](https://github.com/grpc/grpc-swift/releases/tag/2.1.0)
+- [gRPC Swift Protobuf 1.0 (March 
2025)](https://github.com/grpc/grpc-swift-protobuf/releases/tag/1.1.0)
+- [gRPC Swift NIO Transport 1.0 (March 
2025)](https://github.com/grpc/grpc-swift-nio-transport/releases/tag/1.0.1)
+- [Apache Arrow Swift](https://github.com/apache/arrow/tree/main/swift)

Review Comment:
   For now, Apache Arrow didn't make a `Swift` release and didn't compile it 
successfully on the latest Swift 6.0 version.
   
   So, I borrowed and edited some files from Apache Arrow like Apache Spark did 
for Apache Hive Thrift Server module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to