Surbhi-Vijay commented on code in PR #50227:
URL: https://github.com/apache/spark/pull/50227#discussion_r1987599381
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala:
##########
@@ -1493,8 +1493,6 @@ class DataFrameSetOperationsSuite extends QueryTest
val union = df1.union(df2)
union.collect()
- checkIfColumnar(union.queryExecution.executedPlan,
- _.isInstanceOf[InMemoryTableScanExec], supported)
checkIfColumnar(union.queryExecution.executedPlan,
Review Comment:
It is already checking it in below method. It collects all the
`InMemoryTableScanExec` and checks if those are columnar.
```
def checkIfColumnar(
plan: SparkPlan,
targetPlan: (SparkPlan) => Boolean,
isColumnar: Boolean): Unit = {
val target = collect(plan) {
case p if targetPlan(p) => p
}
assert(target.nonEmpty)
assert(target.forall(_.supportsColumnar == isColumnar))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
