cloud-fan commented on code in PR #49908:
URL: https://github.com/apache/spark/pull/49908#discussion_r1994682964
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Mode.scala:
##########
@@ -188,7 +188,8 @@ case class Mode(
assert(orderingFilled || (!orderingFilled && reverseOpt.isEmpty))
- override def withOrderingWithinGroup(orderingWithinGroup: Seq[SortOrder]):
AggregateFunction = {
+ override def withOrderingWithinGroup(
+ orderingWithinGroup: Seq[SortOrder], u: UnresolvedFunction):
AggregateFunction = {
Review Comment:
It's pretty weird to have `UnresolvedFunction` parameter in this API
`withOrderingWithinGroup`.
I'm not quite convinced by this refactoring. `ListAgg` is probably the only
special case and I think it's fine to have a dedicated check for this special
case in `CheckAnalysis`. We can revisit it later when we do need to add more
special cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
