HeartSaVioR commented on PR #49897: URL: https://github.com/apache/spark/pull/49897#issuecomment-2728059888
According to https://lists.apache.org/thread/25xct2zv31kh1plpy766crs3bd6go5s6, I'm -0.99 on this PR, and I'm willing to cast -1 on this PR, because my comment remains unaddressed for more than 1 month from merging this PR. https://github.com/apache/spark/pull/49897#issuecomment-2652486115 > Let's fix in master/4.0 first to avoid making more releases shipping this. We should probably think through how to not break 3.5 itself + upgrading from 3.5 to 4.0+ when fixing in 3.5. If we weren't released this in 3.5 that'd be ideal but... I got thumbs up, so this is not something I only think this is critical. There are argument that "users can upgrade to Spark 3.5.5 before Spark 4.0.0", which I do not believe I agree with. Since both are casting -1 for each other's proposal, I think my comment is NOT addressed. I'm waiting for feedback in dev@, but if we fail to make consensus on the approach on migration, I really have to cast -1 and revert this PR in master/4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
