yaooqinn commented on code in PR #50287: URL: https://github.com/apache/spark/pull/50287#discussion_r1998351674
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/timeExpressions.scala: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.catalyst.expressions + +import java.time.DateTimeException + +import org.apache.spark.sql.catalyst.expressions.objects.Invoke +import org.apache.spark.sql.catalyst.util.TimeFormatter +import org.apache.spark.sql.errors.QueryExecutionErrors +import org.apache.spark.sql.internal.types.StringTypeWithCollation +import org.apache.spark.sql.types.{AbstractDataType, ObjectType, TimeType} +import org.apache.spark.unsafe.types.UTF8String + +/** + * Parses a column to a time based on the given format. + */ +// scalastyle:off line.size.limit +@ExpressionDescription( + usage = """ + _FUNC_(str[, format]) - Parses the `str` expression with the `format` expression to + a time. Returns null with invalid input. By default, it follows casting rules to a time if + the `format` is omitted. + """, + arguments = """ + Arguments: + * str - A string to be parsed to time. + * format - Time format pattern to follow. See <a href="https://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html";>Datetime Patterns</a> for valid + time format patterns. + """, + examples = """ + Examples: + > SELECT _FUNC_('00:12:00'); + 00:12:00 + > SELECT _FUNC_('12.10.05', 'HH.mm.ss'); + 12:10:05 + """, + group = "datetime_funcs", + since = "4.1.0") +// scalastyle:on line.size.limit +case class ToTime(str: Expression, format: Option[Expression]) + extends RuntimeReplaceable with ExpectsInputTypes { + + def this(str: Expression, format: Expression) = this(str, Option(format)) + def this(str: Expression) = this(str, None) + + private def invokeParser( + fmt: Option[String] = None, + arguments: Seq[Expression] = children): Expression = { + Invoke( + targetObject = Literal.create(ToTimeParser(fmt), ObjectType(classOf[ToTimeParser])), + functionName = "parse", + dataType = TimeType(), + arguments = arguments, + methodInputTypes = arguments.map(_.dataType)) + } + + override lazy val replacement: Expression = format match { + case None => invokeParser() + case Some(expr) if expr.foldable => invokeParser(Some(expr.eval().toString), Seq(str)) Review Comment: Will it be possible to hit NPE? e.g. `Literal.create(null).eval().toString`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
