BOOTMGR commented on code in PR #49678:
URL: https://github.com/apache/spark/pull/49678#discussion_r2000149013


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala:
##########
@@ -2704,7 +2704,7 @@ class SQLQuerySuite extends SQLQuerySuiteBase with 
DisableAdaptiveExecutionSuite
                     checkAnswer(sql(s"SELECT id FROM $targetTable"),
                       Row(1) :: Row(2) :: Row(3) :: Nil)
                     spark.sparkContext.listenerBus.waitUntilEmpty()
-                    assert(commands.size == 3)
+                    assert(commands.size == 4)

Review Comment:
   I ran this test multiple times locally but it never failed. I also triggered 
test case execution with some debug logs on CI twice but it did not fail there 
either. 
   
   This change adds one extra execution stage (which was not tracker earlier) 
due to RDD mapping needed by ColumnarToRow transition. I will check If that 
codebase has any dynamic behaviour but most likely that should not be the case 
since all parameters and data is always the same. 
   
   It could be some other change impacting execution too so I'll do some more 
runs today to find which extra node is getting added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to