Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/6648#discussion_r31747942
--- Diff:
core/src/main/java/org/apache/spark/shuffle/unsafe/UnsafeShuffleWriter.java ---
@@ -147,7 +150,7 @@ public void write(scala.collection.Iterator<Product2<K,
V>> records) throws IOEx
closeAndWriteOutput();
success = true;
} finally {
- if (!success) {
+ if (!success && sorter != null) {
--- End diff --
this isn't necessary for this patch, but it prevents an NPE if something
goes wrong in `closeAndWriteOutput` after `sorter` is set to `null`. (eg.,
when I was working on this and introduced a bug in `closeAndWriteOutput` that I
needed to debug, the actual error was swallowed and instead i just got an NPE
here)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
