Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/6642#issuecomment-109003390
Thanks @Emaasit -- this is a useful change. Couple of high level things
1. Could you open a new JIRA for this ? The 'Contributing Code changes'
section of
https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark might
be helpful to follow
2. There are a bunch of Rstudio files in the change which need to be
removed from the PR. Also the data file looks like its 200k lines -- so it
might be too large to keep in github. I'd suggest putting the file on s3 or
somewhere else and including a line at the top with instructions on how to get
the data (I can put the file on s3 if you need help with this).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
