LuciferYang commented on code in PR #50187:
URL: https://github.com/apache/spark/pull/50187#discussion_r2011355693


##########
connect-examples/server-library-example/pom.xml:
##########
@@ -36,7 +36,8 @@
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <scala.binary>2.13</scala.binary>
     <scala.version>2.13.15</scala.version>
-    <protobuf.version>3.25.4</protobuf.version>
-    <spark.version>4.0.0-preview2</spark.version>
+    <protobuf.version>4.29.3</protobuf.version>
+    <spark.version>4.1.0-SNAPSHOT</spark.version>
+    <connect.guava.version>33.4.0-jre</connect.guava.version>

Review Comment:
   > I'd like to avoid inheriting the parent pom as that would lead to the 
project pulling in Spark's default shading rules, version definitions etc. In 
this specific case, it wouldn't be favourable as it's intended to demonstrate 
the extension's development using a minimal set of dependencies (spark-sql-api, 
spark-connect-client, etc.).
   
   
   After some consideration, if this project does not want to inherit Spark's 
parent `pom.xml`, it might be necessary to first deploy the Spark codebase 
corresponding to the this commit to a local repository. Then, the current 
project would need to be built using the 
`-Dmaven.repo.local=/path/to/local/repository` option.
   
   Another possible approach is to configure the ASF snapshot repository, but 
in this case, the project will not obtain a timely snapshot but rather a 
nightly build.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to