ueshin commented on code in PR #49890:
URL: https://github.com/apache/spark/pull/49890#discussion_r2017773133
##########
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala:
##########
@@ -274,7 +274,7 @@ private[spark] abstract class BasePythonRunner[IN, OUT](
worker.stop()
} catch {
case e: Exception =>
- logWarning("Failed to stop worker")
+ logWarning("Failed to stop worker", e)
Review Comment:
Shall we use `log" ... "`, even though there is no `MDC` embedded?
```suggestion
logWarning(log"Failed to stop worker", e)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
