Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6360#discussion_r31771182
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -548,8 +596,13 @@ private[spark] class Client(
         logInfo("Setting up container launch context for our AM")
         val appId = newAppResponse.getApplicationId
         val appStagingDir = getAppStagingDir(appId)
    -    val localResources = prepareLocalResources(appStagingDir)
         val launchEnv = setupLaunchEnv(appStagingDir)
    +    val localResources = prepareLocalResources(appStagingDir)
    +
    +    // Set the environment variables to be passed on to the executors.
    +    distCacheMgr.setDistFilesEnv(launchEnv)
    +    distCacheMgr.setDistArchivesEnv(launchEnv)
    --- End diff --
    
    I noticed that we order some of these code blocks around in this patch. Is 
there a particular reason for it? Have you verified that it's safe to do so?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to