micheal-o commented on code in PR #50512:
URL: https://github.com/apache/spark/pull/50512#discussion_r2034333449
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -1378,19 +1399,26 @@ class RocksDBFileMapping {
*/
private def getDfsFileForSave(
fileManager: RocksDBFileManager,
- localFileName: String,
+ localFile: File,
versionToSave: Long): Option[RocksDBImmutableFile] = {
- getDfsFileWithVersionCheck(fileManager, localFileName, _ >= versionToSave)
+ getDfsFileWithIncompatibilityCheck(
+ fileManager,
+ localFile.getName,
+ (dfsFileVersion, dfsFile) =>
+ // The DFS file is not the same as the file we want to save, either if
+ // the DFS file was added in the same or higher version, or the file
size is different
+ dfsFileVersion >= versionToSave || dfsFile.sizeBytes !=
localFile.length()
Review Comment:
Already contains the info in dfsFile. See `RocksDBSstFile` case class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
