GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/6660
[SPARK-8117] [SQL] Move codegen implementation into Expression
This PR move codegen implementation of expressions into Expression class
itself, make it easy to manage.
It introduces two APIs in Expression:
```
def gen(ctx: CodeGenContext): EvaluatedExpression
def genSource(ctx: CodeGenContext, ev: EvaluatedExpression): String
```
gen(ctx) will call genSource(ctx, ev) to generate Java source code for the
current expression. A expression needs to override `genSource()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davies/spark codegen
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/6660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6660
----
commit 593d61704844989e5d2e61d39efe4d7b7a0e1d1a
Author: Davies Liu <[email protected]>
Date: 2015-06-03T22:27:44Z
pushing codegen into Expression
commit 3ff25f81a8fc6840b5c6dc75377fc89e41454586
Author: Davies Liu <[email protected]>
Date: 2015-06-04T00:45:19Z
refactor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]