Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6625#discussion_r31776910
  
    --- Diff: 
core/src/main/scala/org/apache/spark/serializer/SerializationDebugger.scala ---
    @@ -169,18 +208,53 @@ private[spark] object SerializationDebugger extends 
Logging {
                 }
                 j += 1
               }
    -
             }
             i += 1
           }
           return List.empty
         }
    +
    +    /**
    +     * Visit a serializable object which has the writeObject() defined.
    +     * Since writeObject() can choose add arbitrary objects at the time of 
serialization,
    +     * the only way to capture all the objects it will serialize is by 
using a
    +     * dummy ObjectOutputStream that collects all the relevant fields for 
further testing.
    --- End diff --
    
    maybe it's worth mentioning that this is the similar to how externalizable 
objects are visited?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to