dongjoon-hyun commented on code in PR #63:
URL:
https://github.com/apache/spark-connect-swift/pull/63#discussion_r2046211840
##########
Sources/SparkConnect/DataFrame.swift:
##########
@@ -217,7 +217,7 @@ public actor DataFrame: Sendable {
values.append(str.asString(i))
Review Comment:
Yes~ This is a part-one implementation to introduce `Row` struct like the
note in the PR description.
> Note that Row is added to support general type fields, but this PR
replaces the existing API's [String?] signature into Row-based signature. The
detailed one-to-one mapping among other types will be handled later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
