Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6652#discussion_r31777847
  
    --- Diff: core/src/test/scala/org/apache/spark/MapOutputTrackerSuite.scala 
---
    @@ -205,4 +205,29 @@ class MapOutputTrackerSuite extends SparkFunSuite {
     //    masterTracker.stop() // this throws an exception
         rpcEnv.shutdown()
       }
    +
    +  test("getLocationsWithLargestOutputs with multiple outputs in same 
machine") {
    +    val rpcEnv = createRpcEnv("test")
    +    val tracker = new MapOutputTrackerMaster(conf)
    +    tracker.trackerEndpoint = 
rpcEnv.setupEndpoint(MapOutputTracker.ENDPOINT_NAME,
    +      new MapOutputTrackerMasterEndpoint(rpcEnv, tracker, conf))
    +    // Setup 3 map tasks
    +    // on hostA with output size 1
    +    // on hostA with output size 1
    +    // on hostB with output size 2
    --- End diff --
    
    Can you do 2, 2, 3 as the sizes here? Otherwise this seems 
non-deterministic, since the two machines have equal sizes of data?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to