cloud-fan commented on code in PR #50680:
URL: https://github.com/apache/spark/pull/50680#discussion_r2058961598
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowFunctionFrame.scala:
##########
@@ -123,9 +123,12 @@ abstract class OffsetWindowFunctionFrameBase(
protected val fillDefaultValue = {
// Collect the expressions and bind them.
val boundExpressions = Seq.fill(ordinal)(NoOp) ++
expressions.toImmutableArraySeq.map { e =>
- if (e.default == null || e.default.foldable && e.default.eval() == null)
{
+ if (e.default == null) {
// The default value is null.
Literal.create(null, e.dataType)
+ } else if (e.default.foldable) {
Review Comment:
The change looks reasonable to me, just to double check: ideally the
optimizer should have already optimized foldable expressions into literals, so
this change won't have any real impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
